Use "bytes" instead of "characters" consistently when talking about length of a `String`.
This commit is contained in:
parent
0bce2485ab
commit
6c217f7b66
|
@ -9,13 +9,13 @@ impl Ticket {
|
|||
panic!("Title cannot be empty");
|
||||
}
|
||||
if title.len() > 50 {
|
||||
panic!("Title cannot be longer than 50 characters");
|
||||
panic!("Title cannot be longer than 50 bytes");
|
||||
}
|
||||
if description.is_empty() {
|
||||
panic!("Description cannot be empty");
|
||||
}
|
||||
if description.len() > 500 {
|
||||
panic!("Description cannot be longer than 500 characters");
|
||||
panic!("Description cannot be longer than 500 bytes");
|
||||
}
|
||||
|
||||
Ticket {
|
||||
|
|
|
@ -44,13 +44,13 @@ mod tests {
|
|||
}
|
||||
|
||||
#[test]
|
||||
#[should_panic(expected = "Title cannot be longer than 50 characters")]
|
||||
#[should_panic(expected = "Title cannot be longer than 50 bytes")]
|
||||
fn title_cannot_be_longer_than_fifty_chars() {
|
||||
Ticket::new(overly_long_title(), valid_description(), "To-Do".into());
|
||||
}
|
||||
|
||||
#[test]
|
||||
#[should_panic(expected = "Description cannot be longer than 500 characters")]
|
||||
#[should_panic(expected = "Description cannot be longer than 500 bytes")]
|
||||
fn description_cannot_be_longer_than_500_chars() {
|
||||
Ticket::new(valid_title(), overly_long_description(), "To-Do".into());
|
||||
}
|
||||
|
|
|
@ -19,13 +19,13 @@ impl Ticket {
|
|||
panic!("Title cannot be empty");
|
||||
}
|
||||
if title.len() > 50 {
|
||||
panic!("Title cannot be longer than 50 characters");
|
||||
panic!("Title cannot be longer than 50 bytes");
|
||||
}
|
||||
if description.is_empty() {
|
||||
panic!("Description cannot be empty");
|
||||
}
|
||||
if description.len() > 500 {
|
||||
panic!("Description cannot be longer than 500 characters");
|
||||
panic!("Description cannot be longer than 500 bytes");
|
||||
}
|
||||
if status != "To-Do" && status != "In Progress" && status != "Done" {
|
||||
panic!("Only `To-Do`, `In Progress`, and `Done` statuses are allowed");
|
||||
|
|
|
@ -11,13 +11,13 @@ mod ticket {
|
|||
panic!("Title cannot be empty");
|
||||
}
|
||||
if title.len() > 50 {
|
||||
panic!("Title cannot be longer than 50 characters");
|
||||
panic!("Title cannot be longer than 50 bytes");
|
||||
}
|
||||
if description.is_empty() {
|
||||
panic!("Description cannot be empty");
|
||||
}
|
||||
if description.len() > 500 {
|
||||
panic!("Description cannot be longer than 500 characters");
|
||||
panic!("Description cannot be longer than 500 bytes");
|
||||
}
|
||||
if status != "To-Do" && status != "In Progress" && status != "Done" {
|
||||
panic!("Only `To-Do`, `In Progress`, and `Done` statuses are allowed");
|
||||
|
|
|
@ -11,13 +11,13 @@ pub mod ticket {
|
|||
panic!("Title cannot be empty");
|
||||
}
|
||||
if title.len() > 50 {
|
||||
panic!("Title cannot be longer than 50 characters");
|
||||
panic!("Title cannot be longer than 50 bytes");
|
||||
}
|
||||
if description.is_empty() {
|
||||
panic!("Description cannot be empty");
|
||||
}
|
||||
if description.len() > 500 {
|
||||
panic!("Description cannot be longer than 500 characters");
|
||||
panic!("Description cannot be longer than 500 bytes");
|
||||
}
|
||||
if status != "To-Do" && status != "In Progress" && status != "Done" {
|
||||
panic!("Only `To-Do`, `In Progress`, and `Done` statuses are allowed");
|
||||
|
|
|
@ -15,13 +15,13 @@ impl Ticket {
|
|||
panic!("Title cannot be empty");
|
||||
}
|
||||
if title.len() > 50 {
|
||||
panic!("Title cannot be longer than 50 characters");
|
||||
panic!("Title cannot be longer than 50 bytes");
|
||||
}
|
||||
if description.is_empty() {
|
||||
panic!("Description cannot be empty");
|
||||
}
|
||||
if description.len() > 500 {
|
||||
panic!("Description cannot be longer than 500 characters");
|
||||
panic!("Description cannot be longer than 500 bytes");
|
||||
}
|
||||
if status != "To-Do" && status != "In Progress" && status != "Done" {
|
||||
panic!("Only `To-Do`, `In Progress`, and `Done` statuses are allowed");
|
||||
|
|
|
@ -14,13 +14,13 @@ impl Ticket {
|
|||
panic!("Title cannot be empty");
|
||||
}
|
||||
if title.len() > 50 {
|
||||
panic!("Title cannot be longer than 50 characters");
|
||||
panic!("Title cannot be longer than 50 bytes");
|
||||
}
|
||||
if description.is_empty() {
|
||||
panic!("Description cannot be empty");
|
||||
}
|
||||
if description.len() > 500 {
|
||||
panic!("Description cannot be longer than 500 characters");
|
||||
panic!("Description cannot be longer than 500 bytes");
|
||||
}
|
||||
if status != "To-Do" && status != "In Progress" && status != "Done" {
|
||||
panic!("Only `To-Do`, `In Progress`, and `Done` statuses are allowed");
|
||||
|
@ -76,14 +76,14 @@ mod tests {
|
|||
}
|
||||
|
||||
#[test]
|
||||
#[should_panic(expected = "Title cannot be longer than 50 characters")]
|
||||
#[should_panic(expected = "Title cannot be longer than 50 bytes")]
|
||||
fn title_cannot_be_longer_than_fifty_chars() {
|
||||
Ticket::new(valid_title(), valid_description(), "To-Do".into())
|
||||
.set_title(overly_long_title())
|
||||
}
|
||||
|
||||
#[test]
|
||||
#[should_panic(expected = "Description cannot be longer than 500 characters")]
|
||||
#[should_panic(expected = "Description cannot be longer than 500 bytes")]
|
||||
fn description_cannot_be_longer_than_500_chars() {
|
||||
Ticket::new(valid_title(), valid_description(), "To-Do".into())
|
||||
.set_description(overly_long_description())
|
||||
|
|
|
@ -1,6 +1,6 @@
|
|||
// TODO: Define a new `Order` type.
|
||||
// It should keep track of three pieces of information: `product_name`, `quantity`, and `unit_price`.
|
||||
// The product name can't be empty and it can't be longer than 300 characters.
|
||||
// The product name can't be empty and it can't be longer than 300 bytes.
|
||||
// The quantity must be strictly greater than zero.
|
||||
// The unit price is in cents and must be strictly greater than zero.
|
||||
// Order must include a method named `total` that returns the total price of the order.
|
||||
|
|
|
@ -12,13 +12,13 @@ impl Ticket {
|
|||
panic!("Title cannot be empty");
|
||||
}
|
||||
if title.len() > 50 {
|
||||
panic!("Title cannot be longer than 50 characters");
|
||||
panic!("Title cannot be longer than 50 bytes");
|
||||
}
|
||||
if description.is_empty() {
|
||||
panic!("Description cannot be empty");
|
||||
}
|
||||
if description.len() > 500 {
|
||||
panic!("Description cannot be longer than 500 characters");
|
||||
panic!("Description cannot be longer than 500 bytes");
|
||||
}
|
||||
if status != "To-Do" && status != "In Progress" && status != "Done" {
|
||||
panic!("Only `To-Do`, `In Progress`, and `Done` statuses are allowed");
|
||||
|
|
|
@ -20,13 +20,13 @@ impl Ticket {
|
|||
panic!("Title cannot be empty");
|
||||
}
|
||||
if title.len() > 50 {
|
||||
panic!("Title cannot be longer than 50 characters");
|
||||
panic!("Title cannot be longer than 50 bytes");
|
||||
}
|
||||
if description.is_empty() {
|
||||
panic!("Description cannot be empty");
|
||||
}
|
||||
if description.len() > 500 {
|
||||
panic!("Description cannot be longer than 500 characters");
|
||||
panic!("Description cannot be longer than 500 bytes");
|
||||
}
|
||||
if status != "To-Do" && status != "In Progress" && status != "Done" {
|
||||
panic!("Only `To-Do`, `In Progress`, and `Done` statuses are allowed");
|
||||
|
|
|
@ -22,13 +22,13 @@ impl Ticket {
|
|||
panic!("Title cannot be empty");
|
||||
}
|
||||
if title.len() > 50 {
|
||||
panic!("Title cannot be longer than 50 characters");
|
||||
panic!("Title cannot be longer than 50 bytes");
|
||||
}
|
||||
if description.is_empty() {
|
||||
panic!("Description cannot be empty");
|
||||
}
|
||||
if description.len() > 500 {
|
||||
panic!("Description cannot be longer than 500 characters");
|
||||
panic!("Description cannot be longer than 500 bytes");
|
||||
}
|
||||
|
||||
Ticket {
|
||||
|
|
|
@ -20,13 +20,13 @@ impl Ticket {
|
|||
panic!("Title cannot be empty");
|
||||
}
|
||||
if title.len() > 50 {
|
||||
panic!("Title cannot be longer than 50 characters");
|
||||
panic!("Title cannot be longer than 50 bytes");
|
||||
}
|
||||
if description.is_empty() {
|
||||
panic!("Description cannot be empty");
|
||||
}
|
||||
if description.len() > 500 {
|
||||
panic!("Description cannot be longer than 500 characters");
|
||||
panic!("Description cannot be longer than 500 bytes");
|
||||
}
|
||||
|
||||
Ticket {
|
||||
|
|
|
@ -21,13 +21,13 @@ impl Ticket {
|
|||
panic!("Title cannot be empty");
|
||||
}
|
||||
if title.len() > 50 {
|
||||
panic!("Title cannot be longer than 50 characters");
|
||||
panic!("Title cannot be longer than 50 bytes");
|
||||
}
|
||||
if description.is_empty() {
|
||||
panic!("Description cannot be empty");
|
||||
}
|
||||
if description.len() > 500 {
|
||||
panic!("Description cannot be longer than 500 characters");
|
||||
panic!("Description cannot be longer than 500 bytes");
|
||||
}
|
||||
|
||||
Ticket {
|
||||
|
@ -59,13 +59,13 @@ mod tests {
|
|||
fn title_cannot_be_longer_than_fifty_chars() {
|
||||
let error =
|
||||
Ticket::new(overly_long_title(), valid_description(), Status::ToDo).unwrap_err();
|
||||
assert_eq!(error, "Title cannot be longer than 50 characters");
|
||||
assert_eq!(error, "Title cannot be longer than 50 bytes");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn description_cannot_be_longer_than_500_chars() {
|
||||
let error =
|
||||
Ticket::new(valid_title(), overly_long_description(), Status::ToDo).unwrap_err();
|
||||
assert_eq!(error, "Description cannot be longer than 500 characters");
|
||||
assert_eq!(error, "Description cannot be longer than 500 bytes");
|
||||
}
|
||||
}
|
||||
|
|
|
@ -25,13 +25,13 @@ impl Ticket {
|
|||
return Err("Title cannot be empty".to_string());
|
||||
}
|
||||
if title.len() > 50 {
|
||||
return Err("Title cannot be longer than 50 characters".to_string());
|
||||
return Err("Title cannot be longer than 50 bytes".to_string());
|
||||
}
|
||||
if description.is_empty() {
|
||||
return Err("Description cannot be empty".to_string());
|
||||
}
|
||||
if description.len() > 500 {
|
||||
return Err("Description cannot be longer than 500 characters".to_string());
|
||||
return Err("Description cannot be longer than 500 bytes".to_string());
|
||||
}
|
||||
|
||||
Ok(Ticket {
|
||||
|
@ -60,7 +60,7 @@ mod tests {
|
|||
}
|
||||
|
||||
#[test]
|
||||
#[should_panic(expected = "Title cannot be longer than 50 characters")]
|
||||
#[should_panic(expected = "Title cannot be longer than 50 bytes")]
|
||||
fn title_cannot_be_longer_than_fifty_chars() {
|
||||
easy_ticket(overly_long_title(), valid_description(), Status::ToDo);
|
||||
}
|
||||
|
|
|
@ -35,13 +35,13 @@ impl Ticket {
|
|||
return Err("Title cannot be empty".to_string());
|
||||
}
|
||||
if title.len() > 50 {
|
||||
return Err("Title cannot be longer than 50 characters".to_string());
|
||||
return Err("Title cannot be longer than 50 bytes".to_string());
|
||||
}
|
||||
if description.is_empty() {
|
||||
return Err("Description cannot be empty".to_string());
|
||||
}
|
||||
if description.len() > 500 {
|
||||
return Err("Description cannot be longer than 500 characters".to_string());
|
||||
return Err("Description cannot be longer than 500 bytes".to_string());
|
||||
}
|
||||
|
||||
Ok(Ticket {
|
||||
|
@ -70,7 +70,7 @@ mod tests {
|
|||
}
|
||||
|
||||
#[test]
|
||||
#[should_panic(expected = "Title cannot be longer than 50 characters")]
|
||||
#[should_panic(expected = "Title cannot be longer than 50 bytes")]
|
||||
fn title_cannot_be_longer_than_fifty_chars() {
|
||||
easy_ticket(overly_long_title(), valid_description(), Status::ToDo);
|
||||
}
|
||||
|
|
|
@ -43,7 +43,7 @@ impl Ticket {
|
|||
}
|
||||
if title.len() > 50 {
|
||||
return Err(TicketNewError::TitleError(
|
||||
"Title cannot be longer than 50 characters".to_string(),
|
||||
"Title cannot be longer than 50 bytes".to_string(),
|
||||
));
|
||||
}
|
||||
if description.is_empty() {
|
||||
|
@ -53,7 +53,7 @@ impl Ticket {
|
|||
}
|
||||
if description.len() > 500 {
|
||||
return Err(TicketNewError::DescriptionError(
|
||||
"Description cannot be longer than 500 characters".to_string(),
|
||||
"Description cannot be longer than 500 bytes".to_string(),
|
||||
));
|
||||
}
|
||||
|
||||
|
@ -84,7 +84,7 @@ mod tests {
|
|||
}
|
||||
|
||||
#[test]
|
||||
#[should_panic(expected = "Title cannot be longer than 50 characters")]
|
||||
#[should_panic(expected = "Title cannot be longer than 50 bytes")]
|
||||
fn title_cannot_be_longer_than_fifty_chars() {
|
||||
easy_ticket(overly_long_title(), valid_description(), Status::ToDo);
|
||||
}
|
||||
|
|
|
@ -71,7 +71,7 @@ mod tests {
|
|||
#[test]
|
||||
fn title_cannot_be_longer_than_fifty_chars() {
|
||||
let err = Ticket::new(overly_long_title(), valid_description(), Status::ToDo).unwrap_err();
|
||||
assert_eq!(err.to_string(), "Title cannot be longer than 50 characters");
|
||||
assert_eq!(err.to_string(), "Title cannot be longer than 50 bytes");
|
||||
}
|
||||
|
||||
#[test]
|
||||
|
@ -79,7 +79,7 @@ mod tests {
|
|||
let err = Ticket::new(valid_title(), overly_long_description(), Status::ToDo).unwrap_err();
|
||||
assert_eq!(
|
||||
err.to_string(),
|
||||
"Description cannot be longer than 500 characters"
|
||||
"Description cannot be longer than 500 bytes"
|
||||
);
|
||||
}
|
||||
}
|
||||
|
|
|
@ -17,11 +17,11 @@ mod status;
|
|||
pub enum TicketNewError {
|
||||
#[error("Title cannot be empty")]
|
||||
TitleCannotBeEmpty,
|
||||
#[error("Title cannot be longer than 50 characters")]
|
||||
#[error("Title cannot be longer than 50 bytes")]
|
||||
TitleTooLong,
|
||||
#[error("Description cannot be empty")]
|
||||
DescriptionCannotBeEmpty,
|
||||
#[error("Description cannot be longer than 500 characters")]
|
||||
#[error("Description cannot be longer than 500 bytes")]
|
||||
DescriptionTooLong,
|
||||
}
|
||||
|
||||
|
|
|
@ -1,5 +1,5 @@
|
|||
// TODO: Implement `TryFrom<String>` and `TryFrom<&str>` for the `TicketDescription` type,
|
||||
// enforcing that the description is not empty and is not longer than 500 characters.
|
||||
// enforcing that the description is not empty and is not longer than 500 bytes.
|
||||
// Implement the traits required to make the tests pass too.
|
||||
|
||||
pub struct TicketDescription(String);
|
||||
|
@ -27,7 +27,7 @@ mod tests {
|
|||
let err = TicketDescription::try_from(description).unwrap_err();
|
||||
assert_eq!(
|
||||
err.to_string(),
|
||||
"The description cannot be longer than 500 characters"
|
||||
"The description cannot be longer than 500 bytes"
|
||||
);
|
||||
}
|
||||
|
||||
|
|
|
@ -27,10 +27,7 @@ mod tests {
|
|||
"A title that's definitely longer than what should be allowed in a development ticket"
|
||||
.to_string();
|
||||
let err = TicketTitle::try_from(title).unwrap_err();
|
||||
assert_eq!(
|
||||
err.to_string(),
|
||||
"The title cannot be longer than 50 characters"
|
||||
);
|
||||
assert_eq!(err.to_string(), "The title cannot be longer than 50 bytes");
|
||||
}
|
||||
|
||||
#[test]
|
||||
|
|
|
@ -5,7 +5,7 @@ pub struct TicketDescription(String);
|
|||
pub enum TicketDescriptionError {
|
||||
#[error("The description cannot be empty")]
|
||||
Empty,
|
||||
#[error("The description cannot be longer than 500 characters")]
|
||||
#[error("The description cannot be longer than 500 bytes")]
|
||||
TooLong,
|
||||
}
|
||||
|
||||
|
@ -61,7 +61,7 @@ mod tests {
|
|||
let err = TicketDescription::try_from(overly_long_description()).unwrap_err();
|
||||
assert_eq!(
|
||||
err.to_string(),
|
||||
"The description cannot be longer than 500 characters"
|
||||
"The description cannot be longer than 500 bytes"
|
||||
);
|
||||
}
|
||||
|
||||
|
|
|
@ -7,7 +7,7 @@ pub struct TicketTitle(String);
|
|||
pub enum TicketTitleError {
|
||||
#[error("The title cannot be empty")]
|
||||
Empty,
|
||||
#[error("The title cannot be longer than 50 characters")]
|
||||
#[error("The title cannot be longer than 50 bytes")]
|
||||
TooLong,
|
||||
}
|
||||
|
||||
|
@ -61,10 +61,7 @@ mod tests {
|
|||
#[test]
|
||||
fn test_try_from_long_string() {
|
||||
let err = TicketTitle::try_from(overly_long_title()).unwrap_err();
|
||||
assert_eq!(
|
||||
err.to_string(),
|
||||
"The title cannot be longer than 50 characters"
|
||||
);
|
||||
assert_eq!(err.to_string(), "The title cannot be longer than 50 bytes");
|
||||
}
|
||||
|
||||
#[test]
|
||||
|
|
Loading…
Reference in New Issue